Angular $sce vs HTML in external locale files

 

A question regarding ng-bind-html whilst upgrading an Angular app from 1.0.8 to 1.2.8:

I have locale strings stored in files named en_GB.json , fr_FR.json , etc. So far, I have allowed the use of HTML within the locale strings to allow the team writing the localized content to apply basic styling or adding inline anchor tags. This would result in the following example JSON: 

{
  "changesLater":     "<strong>Don't forget</strong> that you can always make changes later." 
  "errorEmailExists": "That email address already exists, please <a href="login">sign in</a> to continue."
}

When using these strings with ng-bind-html="myStr" , I understand that I now need to use $sce.trustAsHtml(myStr) . I could even write a filter as suggested in this StackOverflow answer which would result in using ng-bind-html="myStr | unsafe" .

Questions:

  • By doing something like this, is my app now insecure? And if so, how might an attacker exploit this?
  • I can understand potential exploits if the source of the displayed HTML string was a user (ie. blog post-style comments that will be displayed to other users), but would my app really be at risk if I'm only displaying HTML from a JSON file hosted on the same domain?
  • Is there any other way I should be looking to achieve the marking-up of externally loaded content strings in an angular app?

  • You are not making your app any less secure. You were already inserting HTML in your page with the old method of ng-bind-html-unsafe. You are still doing the same thing, except now you have to explicitly trust the source of the HTML rather than just specifying that part of your template can output raw HTML. Requiring the use of $sce makes it harder to accidentally accept raw HTML from an untrusted source - in the old method where you only declared the trust in the template, bad input might make its way into your model in ways you didn't think of.

  • If the content comes from your domain, or a domain you control, then you're safe - at least as safe as you can be. If someone is somehow able to highjack the payload of a response from your own domain, then your security is already all manner of screwed. Note, however, you should definitely not ever call $sce.trustAsHtml on content that comes from a domain that isn't yours.

  • Apart from maintainability concerns, I don't see anything wrong with the way you're doing it. Having a ton of HTML live in a JSON file is maybe not ideal, but as long as the markup is reasonably semantic and not too dense, I think it's fine. If the markup becomes significantly more complex, I'd consider splitting it into separate angular template files or directives as needed, rather than trying to manage a bunch of markup wrapped in JSON strings.

    • 链接地址: http://www.djcxy.com/p/76960.html

    上一篇: 数据库查询的位置

    下一篇: Angular $ sce vs外部区域设置文件中的HTML