android Lazy image load of ListView not working properly

I am tying to lazy load images into my ListView, the images are loading fine, but I've a problem. While loading the images get interchanged.

Let's say that the ListView has 10 rows. It loads the images for 1st row, it displays it in the 1st row, then it loads the image for the 2nd row. It displays in the 2nd row for a moment and then it displays the image for the 2nd row in the 1st row. Then the ImageView in row1 switches between images of 1st row and 2nd. Similarly while loading images of next rows. the previous row's images get switched between. And then after loading all the images, everything gets displayed correctly.

Here's my code

Adapater class:

public class FamilyMemberListAdapter extends ArrayAdapter<Map<String, String>> {
    List<Map<String, String>> familyMemberList = new ArrayList<Map<String, String>>();
    private Activity activity;

    public FamilyMemberListAdapter(Activity activity,
            List<Map<String, String>> familyMemberList) {
        super(activity, R.layout.activity_gch_family_members, familyMemberList);
        this.activity = activity;
        this.familyMemberList = familyMemberList;
    }

    @Override
    public View getView(int position, View convertView, ViewGroup parent) {
        ViewHolder holder;
        if (convertView == null) {
            convertView = LayoutInflater.from(this.getContext()).inflate(
                    R.layout.activity_gch_family_member_item, parent, false);
            holder = new ViewHolder();
            holder.lblFamilyMemberName = (TextView) convertView
                    .findViewById(R.id.lblFamilyMemberItem);
            holder.lblFamilyMemberRelation = (TextView) convertView
                    .findViewById(R.id.lblFamilyMemberRelationItem);
            holder.imgProfilePic = (ImageView) convertView
                    .findViewById(R.id.imgvProfilePic);
            convertView.setTag(holder);
        } else {
            holder = (ViewHolder) convertView.getTag();
        }

        int accountId = Integer.valueOf(familyMemberList.get(position).get(
                "accountId"));
        holder.lblFamilyMemberName.setText("Name: "
                + familyMemberList.get(position).get("name"));
        holder.lblFamilyMemberRelation.setText("Relation: "
                + familyMemberList.get(position).get("relation"));
        if (holder.imgProfilePic != null) {
            new ImageDownloaderTask(holder.imgProfilePic).execute(String
                    .valueOf(accountId));
        }
        return convertView;
    }

    @Override
    public int getCount() {
        return familyMemberList.size();
    }

    static class ViewHolder {
        TextView lblFamilyMemberName;
        TextView lblFamilyMemberRelation;
        ImageView imgProfilePic;
    }
}

Imageloader AsyncTask:

public class ImageDownloaderTask extends AsyncTask<String, Void, Bitmap> {
    private final WeakReference<ImageView> imageViewReference;

    public ImageDownloaderTask(ImageView imageView) {
        imageViewReference = new WeakReference<ImageView>(imageView);
    }

    @Override
    protected Bitmap doInBackground(String... params) {
        String responseText = null;
        HttpClient httpClient = ServiceHelper.getHttpClient();
        HttpContext localContext = new BasicHttpContext();
        HttpGet httpGet = new HttpGet(RestApiPaths.GET_PROFILE_PIC + accountId);
        try {
            HttpResponse response = httpClient.execute(httpGet);
            int statusCode = response.getStatusLine().getStatusCode();
            final HttpEntity entity = response.getEntity();
            if (entity != null) {
                InputStream inputStream = null;
                try {
                    // getting contents from the stream
                    inputStream = entity.getContent();

                    // decoding stream data back into image Bitmap that android understands
                    final Bitmap bitmap = BitmapFactory.decodeStream(inputStream);
                    return bitmap;
                 } finally {
                    if (inputStream != null) {
                        inputStream.close();
                    }
                    entity.consumeContent();
                }
            }
            Log.d(TAG, responseText);
        } catch (ClientProtocolException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        return null;
    }

    @Override
    protected void onPostExecute(Bitmap bitmap) {
        if (isCancelled()) {
            bitmap = null;
        }

        if (imageViewReference != null) {
            ImageView imageView = imageViewReference.get();
            if (imageView != null) {
                if (bitmap != null) {
                    imageView.setImageBitmap(bitmap);
                } else {
                    Drawable placeholder = imageView.getContext().getResources().getDrawable(R.drawable.holder_pic_side);
                    imageView.setImageDrawable(placeholder);
                }
            }
        }
    }
}

I've created a Static class for the ListView items. Still Why is the images go on interchanging while loading. Please tell me what I'm doing wrong here.

---

Add holder.imgProfilePic.setTag(accountId); before you call the AsyncTask. Add an extra parameter accountId to your task. Then in onPostExecute check if it is the same accountId as in the image view

---

Maybe try to use libraries like picasso or universal image loader or something. They have solved most of problems with image loading

链接地址: http://www.djcxy.com/p/93130.html

上一篇: 我的代码以外的空指针异常

下一篇: Android懒惰的图像加载ListView无法正常工作